From b8e7dc1317e263884c2e10bcf4ff822857a545a5 Mon Sep 17 00:00:00 2001 From: Corentin LABBE Date: Thu, 4 Jan 2018 11:17:53 +0100 Subject: xnbd: fix killing of old xnbd-server process MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Our LAB run lots of XNBD jobs, and lots of xnbd-server process were never killed. The port allocated is not used for killing, eg self.parameters['protocols']['lava-xnbd']['port'] is still set to auto. As suggested by Neil Williams, it's better to "create a dedicated function which is called from the test job" So this patch adds a "set_port" function which get the right port number. Existing jobs should now add this: protocols: lava-xnbd: - action: nbd-deploy request: set_port after actions: - deploy: Change-Id: I6b464314ac2c1a137162b0a7f955c4501f8a7424 Suggested-by: Jan-Simon Möller --- lava_dispatcher/test/sample_jobs/bbb-initrd-nbd.yaml | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'lava_dispatcher/test') diff --git a/lava_dispatcher/test/sample_jobs/bbb-initrd-nbd.yaml b/lava_dispatcher/test/sample_jobs/bbb-initrd-nbd.yaml index 276861f7a..67356cb5b 100644 --- a/lava_dispatcher/test/sample_jobs/bbb-initrd-nbd.yaml +++ b/lava_dispatcher/test/sample_jobs/bbb-initrd-nbd.yaml @@ -43,3 +43,7 @@ actions: - 'root@beaglebone:' timeout: minutes: 4 + protocols: + lava-xnbd: + - action: nbd-deploy + request: set_port -- cgit v1.2.3