From ecb8416d5ede3e5eae463802721c2a12216b61a4 Mon Sep 17 00:00:00 2001 From: Michael Prokop Date: Thu, 17 Jun 2010 01:49:09 +0200 Subject: lsinitramfs: be more defensive against cmdline options * make sure the specified file(s) can be read * redirect error message to stderr * support -h/--help option * variable quoting Signed-off-by: Michael Prokop --- lsinitramfs | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) (limited to 'lsinitramfs') diff --git a/lsinitramfs b/lsinitramfs index aea7747..809445f 100755 --- a/lsinitramfs +++ b/lsinitramfs @@ -3,12 +3,24 @@ usage() { echo "Usage: $(basename $0) " - exit 1 } -[ $# -eq 0 ] && usage +if [ "$#" -eq 0 ] ; then + usage >&2 + exit 1 +fi + +if [ "$1" = "-h" ] || [ "$1" = "--help" ] ; then + usage + exit 0 +fi -for i in $*; do - echo $i - zcat $i | cpio --extract --verbose --quiet --list +for i in "$*" ; do + if ! [ -r "$i" ] ; then + echo "Specified file could not be read." >&2 + exit 1 + else + echo "$i" + zcat "$i" | cpio --extract --verbose --quiet --list + fi done -- cgit v1.2.3