aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Mayer <markus.mayer@linaro.org>2013-11-07 16:22:36 -0800
committerMarkus Mayer <markus.mayer@linaro.org>2013-11-08 12:15:58 -0800
commitab2bb2e264ad920a860ff9af8fbe35fbf7bc8b8a (patch)
treeaa4f9c69bde3c1413013a51311c5363f1e163e5b
parentafb3690c3cbd0bd82b267934b419c0643e2b938a (diff)
gpio: bcm281xx: Fix return value of bcm_kona_gpio_get()review/gpio-get-v2
We need to return the corresponding bit for a particular GPIO. This bit contains shift not mask. Signed-off-by: Markus Mayer <markus.mayer@linaro.org> Reviewed-by: Tim Kryger <tim.kryger@linaro.org> Reviewed-by: Matt Porter <matt.porter@linaro.org>
-rw-r--r--drivers/gpio/gpio-bcm-kona.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index 72c927dc3be..db473f1ed45 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -158,7 +158,7 @@ static int bcm_kona_gpio_get(struct gpio_chip *chip, unsigned gpio)
spin_unlock_irqrestore(&kona_gpio->lock, flags);
/* return the specified bit status */
- return !!(val & bit);
+ return (val >> bit) & 1;
}
static int bcm_kona_gpio_direction_input(struct gpio_chip *chip, unsigned gpio)