diff options
author | Luca Vizzarro <Luca.Vizzarro@arm.com> | 2020-06-30 10:30:30 +0100 |
---|---|---|
committer | Chris Kay <chris@cjkay.com> | 2020-07-03 14:30:27 +0100 |
commit | b2519bc5ea5062f4d19bc94c3b903ee10eb3e46c (patch) | |
tree | a39d53913f1a5c370cca9533b1bf1ecb747ad1d9 /product/sgm775 | |
parent | ed2cec6b81d01b96ec1a2e857d472c541aadbeb3 (diff) |
sgm775/config_scmi: Fix notification API ids
The SCMI configuration for the FVP SGM775 did not have the
notification API correctly set up on its domains. As a
consequence the SCP was not sending any notification to its
subscribers, rendering it non conformant to the SCMI v2 specs,
hence failing the SCMI v2 Test Suite.
Change-Id: Idbf109711bb05ed506636e5fd5922e35e9a3d5e3
Signed-off-by: Luca Vizzarro <Luca.Vizzarro@arm.com>
Diffstat (limited to 'product/sgm775')
-rw-r--r-- | product/sgm775/scp_ramfw/config_dvfs.c | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/product/sgm775/scp_ramfw/config_dvfs.c b/product/sgm775/scp_ramfw/config_dvfs.c index 6a16cd94..bd0bed1b 100644 --- a/product/sgm775/scp_ramfw/config_dvfs.c +++ b/product/sgm775/scp_ramfw/config_dvfs.c @@ -10,6 +10,7 @@ #include <mod_dvfs.h> #include <mod_sid.h> +#include <mod_scmi_perf.h> #include <fwk_assert.h> #include <fwk_element.h> @@ -26,7 +27,9 @@ static const struct mod_dvfs_domain_config cpu_group_little = { .clock_id = FWK_ID_ELEMENT_INIT(FWK_MODULE_IDX_CLOCK, 1), .alarm_id = FWK_ID_SUB_ELEMENT_INIT(FWK_MODULE_IDX_TIMER, 0, CONFIG_TIMER_DVFS_CPU_GROUP_LITTLE), - .notification_id = FWK_ID_NONE_INIT, + .notification_id = FWK_ID_MODULE_INIT(FWK_MODULE_IDX_SCMI_PERF), + .notification_api_id = FWK_ID_API_INIT(FWK_MODULE_IDX_SCMI_PERF, + MOD_SCMI_PERF_DVFS_NOTIFICATION_API), .retry_ms = 1, .latency = 1200, .sustained_idx = 2, @@ -60,7 +63,9 @@ static const struct mod_dvfs_domain_config cpu_group_big = { .clock_id = FWK_ID_ELEMENT_INIT(FWK_MODULE_IDX_CLOCK, 0), .alarm_id = FWK_ID_SUB_ELEMENT_INIT(FWK_MODULE_IDX_TIMER, 0, CONFIG_TIMER_DVFS_CPU_GROUP_BIG), - .notification_id = FWK_ID_NONE_INIT, + .notification_id = FWK_ID_MODULE_INIT(FWK_MODULE_IDX_SCMI_PERF), + .notification_api_id = FWK_ID_API_INIT(FWK_MODULE_IDX_SCMI_PERF, + MOD_SCMI_PERF_DVFS_NOTIFICATION_API), .retry_ms = 1, .latency = 1200, .sustained_idx = 2, @@ -94,7 +99,9 @@ static const struct mod_dvfs_domain_config gpu = { .clock_id = FWK_ID_ELEMENT_INIT(FWK_MODULE_IDX_CLOCK, 2), .alarm_id = FWK_ID_SUB_ELEMENT_INIT(FWK_MODULE_IDX_TIMER, 0, CONFIG_TIMER_DVFS_GPU), - .notification_id = FWK_ID_NONE_INIT, + .notification_id = FWK_ID_MODULE_INIT(FWK_MODULE_IDX_SCMI_PERF), + .notification_api_id = FWK_ID_API_INIT(FWK_MODULE_IDX_SCMI_PERF, + MOD_SCMI_PERF_DVFS_NOTIFICATION_API), .retry_ms = 1, .latency = 1200, .sustained_idx = 4, |