diff options
| author | Luca Vizzarro <Luca.Vizzarro@arm.com> | 2020-09-09 13:50:43 +0100 |
|---|---|---|
| committer | nicola-mazzucato-arm <42373140+nicola-mazzucato-arm@users.noreply.github.com> | 2020-10-22 14:39:59 +0100 |
| commit | f1c60ef117140b79416dad1c1c2b8131ff0d30fb (patch) | |
| tree | 0265fa37e9dc8607f2868116ef3de9f3e9bcadcc | |
| parent | f17fa7b42c3c48236bff9cdb717f0e58ffa907a8 (diff) | |
mod_scmi_clock: Fix config set invalid params
SCMI v2 specifies that any reserved bits in command's attributes
must be zero. This commit enables compliance to CLOCK_CONFIG_SET
Change-Id: I5de91df28c2f12a26f0e10e797a1335c5be0c417
Signed-off-by: Luca Vizzarro <Luca.Vizzarro@arm.com>
| -rw-r--r-- | module/scmi_clock/src/mod_scmi_clock.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/module/scmi_clock/src/mod_scmi_clock.c b/module/scmi_clock/src/mod_scmi_clock.c index 1a7136e7..fd5b0467 100644 --- a/module/scmi_clock/src/mod_scmi_clock.c +++ b/module/scmi_clock/src/mod_scmi_clock.c @@ -932,6 +932,11 @@ static int scmi_clock_config_set_handler(fwk_id_t service_id, goto exit; } + if ((parameters->attributes & ~SCMI_CLOCK_CONFIG_SET_ENABLE_MASK) != 0) { + return_values.status = SCMI_INVALID_PARAMETERS; + goto exit; + } + struct event_set_state_request_data data = { .state = enable ? MOD_CLOCK_STATE_RUNNING : MOD_CLOCK_STATE_STOPPED }; |