diff options
| author | Luca Vizzarro <Luca.Vizzarro@arm.com> | 2020-10-08 19:42:22 +0100 |
|---|---|---|
| committer | nicola-mazzucato-arm <42373140+nicola-mazzucato-arm@users.noreply.github.com> | 2020-10-22 14:39:59 +0100 |
| commit | 274aa3f44a30601bc7da2d7451464734126c9521 (patch) | |
| tree | 1ca0b495057b58629abef98e13ed8cd8068c5747 | |
| parent | 0882bb4d644d8e119a9a2cd0e3661b2726bcea8c (diff) | |
mod_scmi_power: Fix invalid device return value
The SCMI power domain protocol does not support notifications
for all the the domains. Specifically, only DEVICE type ones do.
The code originally correctly picked this up and returned with an error,
with the exception that this error was SCMI_DENIED. As per section 4.1.4
of the SCMI v2 spec, this error is dedicated to permissions-related
problems. As this is not the case, this
commit replaces this error with a more suitable SCMI_NOT_SUPPORTED.
Change-Id: I537391bcce57a7849dae2ed26924ca1ad0b1016b
Signed-off-by: Luca Vizzarro <Luca.Vizzarro@arm.com>
| -rw-r--r-- | module/scmi_power_domain/src/mod_scmi_power_domain.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/module/scmi_power_domain/src/mod_scmi_power_domain.c b/module/scmi_power_domain/src/mod_scmi_power_domain.c index d519642e..ab271d33 100644 --- a/module/scmi_power_domain/src/mod_scmi_power_domain.c +++ b/module/scmi_power_domain/src/mod_scmi_power_domain.c @@ -808,7 +808,7 @@ static int scmi_pd_power_state_notify_handler( * agent that is notified" */ if (pd_type != MOD_PD_TYPE_DEVICE && pd_type != MOD_PD_TYPE_DEVICE_DEBUG) { - return_values.status = SCMI_DENIED; + return_values.status = SCMI_NOT_SUPPORTED; goto exit; } |