Platform/RaspberryPi: Rip out FdtDxe logic to use internal DTB

Initially, FdtDxe used an internal (embedded in UEFI) FDT, because it
was neither understood how to consume the one loaded by the VideoCore
firmware, nor understood just how important it is to use the DTB
provided by config.txt.

Embedding the DT was a bad idea, because:
- Permanently stale
- No overlays

Also, on devices like the Pi 4 you _have_ to have a DT around for the
start4 VPU firmware to pick up, otherwise the board is left in an
inconsistent state. So we're being prescriptive now about DT use with
config.txt, which means this internal DT logic is dead code.

Further FdtDxe cleanups are possible and will be handled separately,
specifically:
- probably no need to use a separate allocation for patched DT (optimize
  memory used)
- suspicious use of EfiBootServicesData (I filed [0] to sort out the real
  requirements)

Testing: Booted Ubuntu 18.04 on Pi 2B (1.2).

[0] https://github.com/ARM-software/ebbr/issues/45

Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
Reviewed-by: Pete Batard <pete@akeo.ie>

1 files changed, 0 insertions, 11 deletions

diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf b/Platform/RaspberryPi/RPi3/RPi3.fdf
index daedc443..e854cd21 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.fdf
+++ b/Platform/RaspberryPi/RPi3/RPi3.fdf
@@ -303,17 +303,6 @@ READ_LOCK_STATUS   = TRUE
   #

   INF Platform/RaspberryPi/Drivers/LogoDxe/LogoDxe.inf

 

-  #

-  # Device Tree support (used by FdtDxe)

-  # GUIDs should match gRaspberryPi#####FdtGuid's from the .dec

-  #

-  FILE FREEFORM = DF5DA223-1D27-47C3-8D1B-9A41B55A18BC {

-    SECTION RAW = Platform/RaspberryPi/$(PLATFORM_NAME)/DeviceTree/bcm2710-rpi-3-b.dtb

-  }

-  FILE FREEFORM = 3D523012-73FE-40E5-892E-1A4DF60F3C0C {

-    SECTION RAW = Platform/RaspberryPi/$(PLATFORM_NAME)/DeviceTree/bcm2710-rpi-3-b-plus.dtb

-  }

-

 [FV.FVMAIN_COMPACT]

 FvAlignment        = 16

 ERASE_POLARITY     = 1