From 685dd5ff54ea9b3333df75427bd91d9601813c23 Mon Sep 17 00:00:00 2001 From: Blaisorblade Date: Sat, 30 Jul 2005 21:07:02 +0200 Subject: [PATCH] sys_get_thread_area does not clear the returned argument CC: sys_get_thread_area does not memset to 0 its struct user_desc info before copying it to user space... since sizeof(struct user_desc) is 16 while the actual datas which are filled are only 12 bytes + 9 bits (across the bitfields), there is a (small) information leak. This was already committed to Linus' repository. Signed-off-by: Paolo 'Blaisorblade' Giarrusso Signed-off-by: Chris Wright --- arch/i386/kernel/process.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/i386/kernel/process.c b/arch/i386/kernel/process.c index 96e3ea6b17c7..173799685df3 100644 --- a/arch/i386/kernel/process.c +++ b/arch/i386/kernel/process.c @@ -827,6 +827,8 @@ asmlinkage int sys_get_thread_area(struct user_desc __user *u_info) if (idx < GDT_ENTRY_TLS_MIN || idx > GDT_ENTRY_TLS_MAX) return -EINVAL; + memset(&info, 0, sizeof(info)); + desc = current->thread.tls_array + idx - GDT_ENTRY_TLS_MIN; info.entry_number = idx; -- cgit v1.2.3