diff options
| author | Chris Redpath <chris.redpath@arm.com> | 2012-06-29 16:07:46 +0100 |
|---|---|---|
| committer | Alex Shi <alex.shi@linaro.org> | 2014-07-16 09:52:31 +0800 |
| commit | 4450ca21f8f91a648a087031601d3fca9d38e926 (patch) | |
| tree | db353b032c317d6a719446825b25845249a7a125 /drivers/video | |
| parent | 0350950f7b4f5436f5f6214d3c05465bb00fd454 (diff) | |
ARM HDLCD: Review comments from Liviu - extraneous memcpy
Signed-off-by: Chris Redpath <chris.redpath@arm.com>
Reviewed-By: Liviu Dudau <liviu.dudau@arm.com>
(cherry picked from commit d81ef6e2c92174b65e1c6af80d05cddfc0c4e7a1)
Signed-off-by: Alex Shi <alex.shi@linaro.org>
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/arm-hdlcd.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/video/arm-hdlcd.c b/drivers/video/arm-hdlcd.c index 8d5409db6b17..f16bb882e0c5 100644 --- a/drivers/video/arm-hdlcd.c +++ b/drivers/video/arm-hdlcd.c @@ -262,10 +262,10 @@ static int hdlcd_set_par(struct fb_info *info) if (!memcmp(&info->var, &cached_var_screeninfo, sizeof(struct fb_var_screeninfo))) { if(old_yoffset != info->var.yoffset) { - /* we only changed yoffset */ + /* we only changed yoffset, and we already + * already recorded it a couple lines up + */ hdlcd_pan_display(&info->var, info); - memcpy(&cached_var_screeninfo, &info->var, - sizeof(struct fb_var_screeninfo)); } /* or no change */ return 0; |