diff options
author | Andrew Bresticker <abrestic@chromium.org> | 2014-04-16 13:40:17 -0700 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-05-13 13:32:54 +0200 |
commit | aa0e5094d6c6117d2c3ba65378c61a36984acb53 (patch) | |
tree | a9708d0a906a870617cff921f023110c6cb53039 /drivers/video | |
parent | 02188246b631f3efa7ec3ec00276af358f1e91c7 (diff) |
pinctrl: as3722: fix handling of GPIO invert bit
commit a73d2e30b46787d478275db36c19222020e29dc5 upstream.
The AS3722_GPIO_INV bit will always be blindly overwritten by
as3722_pinctrl_gpio_set_direction() and will be ignored when
setting the value of the GPIO in as3722_gpio_set() since the
enable_gpio_invert flag is never set. This will cause an
initially inverted GPIO to toggle when requested as an output,
which could be problematic if, for example, the GPIO controls
a critical regulator.
Instead of setting up the enable_gpio_invert flag, just leave
the invert bit alone and check it before setting the GPIO value.
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
Reviewed-by: Stephen Warren <swarren@nvidia.com>
Tested-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/video')
0 files changed, 0 insertions, 0 deletions