diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2013-01-21 20:48:17 +0100 |
|---|---|---|
| committer | Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com> | 2013-02-06 11:02:50 -0200 |
| commit | 3855e594c26d66e498811061724227c1f18cec3b (patch) | |
| tree | f71484833101dbd3cb6cbf38265728f7af6f2b30 /kernel | |
| parent | c2239904f199b3725b8a8d52bca41d6f647feafc (diff) | |
wake_up_process() should be never used to wakeup a TASK_STOPPED/TRACED task
commit 9067ac85d533651b98c2ff903182a20cbb361fcb upstream.
wake_up_process() should never wakeup a TASK_STOPPED/TRACED task.
Change it to use TASK_NORMAL and add the WARN_ON().
TASK_ALL has no other users, probably can be killed.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/sched/core.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 9f81a3ac92fc..3231df808029 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -1686,7 +1686,8 @@ out: */ int wake_up_process(struct task_struct *p) { - return try_to_wake_up(p, TASK_ALL, 0); + WARN_ON(task_is_stopped_or_traced(p)); + return try_to_wake_up(p, TASK_NORMAL, 0); } EXPORT_SYMBOL(wake_up_process); |