diff options
| author | Johan Hovold <johan@kernel.org> | 2015-01-26 12:02:45 +0100 |
|---|---|---|
| committer | Zefan Li <lizefan@huawei.com> | 2015-04-14 17:33:59 +0800 |
| commit | 8566a606c062d4ff1982250c96740e8b4e9c8758 (patch) | |
| tree | 0041bf53635b9b889af5ab602feaa865643c9e12 | |
| parent | db6c390a258149666ccee4a0bea5f8c7acb033bc (diff) | |
gpio: sysfs: fix memory leak in gpiod_export_link
commit 0f303db08df0df9bd0966443ad6001e63960af16 upstream.
Fix memory leak in the gpio sysfs interface due to failure to drop
reference to device returned by class_find_device when creating a link.
Fixes: a4177ee7f1a8 ("gpiolib: allow exported GPIO nodes to be named
using sysfs links")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
[lizf: Backported to 3.4: adjust filename]
Signed-off-by: Zefan Li <lizefan@huawei.com>
| -rw-r--r-- | drivers/gpio/gpiolib.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 6c4443b191d4..011d13402525 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -825,6 +825,7 @@ int gpio_export_link(struct device *dev, const char *name, unsigned gpio) if (tdev != NULL) { status = sysfs_create_link(&dev->kobj, &tdev->kobj, name); + put_device(tdev); } else { status = -ENODEV; } |