aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2012-10-04 14:30:25 +0100
committerSteven Rostedt <rostedt@goodmis.org>2014-01-03 21:15:30 -0500
commit6cab4648d5b1f969309e92c5b823a2f0c1c772df (patch)
tree08a23f6f06248df953bcd557d9967a01d5b00386
parentf7a8a7cc4ddfbf107fb7002a669a124755d99238 (diff)
softirq: Make serving softirqs a task flag
Avoid the percpu softirq_runner pointer magic by using a task flag. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r--include/linux/sched.h1
-rw-r--r--kernel/softirq.c20
2 files changed, 4 insertions, 17 deletions
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 0aec42841f85..63c15bc6bd44 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1671,6 +1671,7 @@ extern void thread_group_cputime_adjusted(struct task_struct *p, cputime_t *ut,
/*
* Per process flags
*/
+#define PF_IN_SOFTIRQ 0x00000001 /* Task is serving softirq */
#define PF_EXITING 0x00000004 /* getting shut down */
#define PF_EXITPIDONE 0x00000008 /* pi exit done on shut down */
#define PF_VCPU 0x00000010 /* I'm a virtual CPU */
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 04e4a5ff774f..155737a2d9b1 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -383,7 +383,6 @@ static void ksoftirqd_clr_sched_params(unsigned int cpu, bool online) { }
* On RT we serialize softirq execution with a cpu local lock
*/
static DEFINE_LOCAL_IRQ_LOCK(local_softirq_lock);
-static DEFINE_PER_CPU(struct task_struct *, local_softirq_runner);
static void __do_softirq_common(int need_rcu_bh_qs);
@@ -438,22 +437,9 @@ void _local_bh_enable(void)
}
EXPORT_SYMBOL(_local_bh_enable);
-/* For tracing */
-int notrace __in_softirq(void)
-{
- if (__get_cpu_var(local_softirq_lock).owner == current)
- return __get_cpu_var(local_softirq_lock).nestcnt;
- return 0;
-}
-
int in_serving_softirq(void)
{
- int res;
-
- preempt_disable();
- res = __get_cpu_var(local_softirq_runner) == current;
- preempt_enable();
- return res;
+ return current->flags & PF_IN_SOFTIRQ;
}
EXPORT_SYMBOL(in_serving_softirq);
@@ -471,7 +457,7 @@ static void __do_softirq_common(int need_rcu_bh_qs)
/* Reset the pending bitmask before enabling irqs */
set_softirq_pending(0);
- __get_cpu_var(local_softirq_runner) = current;
+ current->flags |= PF_IN_SOFTIRQ;
lockdep_softirq_enter();
@@ -482,7 +468,7 @@ static void __do_softirq_common(int need_rcu_bh_qs)
wakeup_softirqd();
lockdep_softirq_exit();
- __get_cpu_var(local_softirq_runner) = NULL;
+ current->flags &= ~PF_IN_SOFTIRQ;
current->softirq_nestcnt--;
}