From db07cbef475af3b9991a8bec62e4ea7749650e5e Mon Sep 17 00:00:00 2001 From: Marcin Kuzminski Date: Wed, 5 Dec 2012 17:32:56 +0100 Subject: fixed issue #671 commenting on pull requests sometimes used old JSON encoder and broke. This changeset replaces it's with RhodeCode json encoder to ensure all data is properly serializable --HG-- branch : beta --- rhodecode/controllers/changeset.py | 7 +++---- rhodecode/controllers/files.py | 2 +- rhodecode/controllers/pullrequests.py | 10 ++++------ 3 files changed, 8 insertions(+), 11 deletions(-) (limited to 'rhodecode/controllers') diff --git a/rhodecode/controllers/changeset.py b/rhodecode/controllers/changeset.py index 1fd01902..68a21d37 100644 --- a/rhodecode/controllers/changeset.py +++ b/rhodecode/controllers/changeset.py @@ -31,11 +31,10 @@ from webob.exc import HTTPForbidden, HTTPBadRequest from pylons import tmpl_context as c, url, request, response from pylons.i18n.translation import _ from pylons.controllers.util import redirect -from pylons.decorators import jsonify +from rhodecode.lib.utils import jsonify -from rhodecode.lib.vcs.exceptions import RepositoryError, ChangesetError, \ +from rhodecode.lib.vcs.exceptions import RepositoryError, \ ChangesetDoesNotExistError -from rhodecode.lib.vcs.nodes import FileNode import rhodecode.lib.helpers as h from rhodecode.lib.auth import LoginRequired, HasRepoPermissionAnyDecorator @@ -47,8 +46,8 @@ from rhodecode.model.db import ChangesetComment, ChangesetStatus from rhodecode.model.comment import ChangesetCommentsModel from rhodecode.model.changeset_status import ChangesetStatusModel from rhodecode.model.meta import Session -from rhodecode.lib.diffs import LimitedDiffContainer from rhodecode.model.repo import RepoModel +from rhodecode.lib.diffs import LimitedDiffContainer from rhodecode.lib.exceptions import StatusChangeOnClosedPullRequestError from rhodecode.lib.vcs.backends.base import EmptyChangeset from rhodecode.lib.utils2 import safe_unicode diff --git a/rhodecode/controllers/files.py b/rhodecode/controllers/files.py index 6b55a1f3..35c6bc2d 100644 --- a/rhodecode/controllers/files.py +++ b/rhodecode/controllers/files.py @@ -31,7 +31,7 @@ import tempfile from pylons import request, response, tmpl_context as c, url from pylons.i18n.translation import _ from pylons.controllers.util import redirect -from pylons.decorators import jsonify +from rhodecode.lib.utils import jsonify from rhodecode.lib import diffs from rhodecode.lib import helpers as h diff --git a/rhodecode/controllers/pullrequests.py b/rhodecode/controllers/pullrequests.py index b05ebf8c..396a30f6 100644 --- a/rhodecode/controllers/pullrequests.py +++ b/rhodecode/controllers/pullrequests.py @@ -33,7 +33,6 @@ from itertools import groupby from pylons import request, response, session, tmpl_context as c, url from pylons.controllers.util import abort, redirect from pylons.i18n.translation import _ -from pylons.decorators import jsonify from rhodecode.lib.compat import json from rhodecode.lib.base import BaseRepoController, render @@ -41,7 +40,10 @@ from rhodecode.lib.auth import LoginRequired, HasRepoPermissionAnyDecorator,\ NotAnonymous from rhodecode.lib import helpers as h from rhodecode.lib import diffs -from rhodecode.lib.utils import action_logger +from rhodecode.lib.utils import action_logger, jsonify +from rhodecode.lib.vcs.exceptions import EmptyRepositoryError +from rhodecode.lib.vcs.backends.base import EmptyChangeset +from rhodecode.lib.diffs import LimitedDiffContainer from rhodecode.model.db import User, PullRequest, ChangesetStatus,\ ChangesetComment from rhodecode.model.pull_request import PullRequestModel @@ -50,10 +52,6 @@ from rhodecode.model.repo import RepoModel from rhodecode.model.comment import ChangesetCommentsModel from rhodecode.model.changeset_status import ChangesetStatusModel from rhodecode.model.forms import PullRequestForm -from rhodecode.lib.vcs.exceptions import EmptyRepositoryError -from rhodecode.lib.vcs.backends.base import EmptyChangeset -from rhodecode.lib.diffs import LimitedDiffContainer -from rhodecode.lib.utils2 import str2bool log = logging.getLogger(__name__) -- cgit v1.2.3