From ce48ff437dd80e6966ca4ffb304ab16eacf6b2ae Mon Sep 17 00:00:00 2001 From: Ben Copeland Date: Mon, 11 Apr 2016 12:46:47 +0100 Subject: Add leading 0 to file permissions Ansible 2.0 breaks on 3 digit octal permissions. Adding leading 0 to octal permissions will pass lint checks. Change-Id: Ica56b2fd00be4f123f39f68401fea547f901931a Signed-off-by: Ben Copeland Reviewed-on: https://review.linaro.org/11314 Reviewed-by: Paul Sokolovsky --- per-service/git-servers/roles/gerrit-bot-user/tasks/main.yml | 4 ++-- per-service/git-servers/roles/gerrit-setup/tasks/gerrit.yml | 2 +- roles/bugzilla/tasks/main.yml | 2 +- roles/colo-router/tasks/main.yml | 6 +++--- roles/sslcert-self-signed/tasks/main.yml | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/per-service/git-servers/roles/gerrit-bot-user/tasks/main.yml b/per-service/git-servers/roles/gerrit-bot-user/tasks/main.yml index 27d1b265..ff8e9aba 100644 --- a/per-service/git-servers/roles/gerrit-bot-user/tasks/main.yml +++ b/per-service/git-servers/roles/gerrit-bot-user/tasks/main.yml @@ -6,13 +6,13 @@ - name: Install linaro-gerrit-bot private SSH key copy: src={{secrets_dir}}/files/linaro-gerrit-bot.key dest=/home/{{git_user}}/.ssh/id_rsa - owner={{git_user}} mode=600 backup=yes + owner={{git_user}} mode=0600 backup=yes tags: - secrets - name: Install linaro-gerrit-bot public SSH key copy: src={{secrets_dir}}/files/linaro-gerrit-bot.pub dest=/home/{{git_user}}/.ssh/id_rsa.pub - owner={{git_user}} mode=600 backup=yes + owner={{git_user}} mode=0600 backup=yes tags: - secrets diff --git a/per-service/git-servers/roles/gerrit-setup/tasks/gerrit.yml b/per-service/git-servers/roles/gerrit-setup/tasks/gerrit.yml index 7e3041e1..a5f5d0d6 100644 --- a/per-service/git-servers/roles/gerrit-setup/tasks/gerrit.yml +++ b/per-service/git-servers/roles/gerrit-setup/tasks/gerrit.yml @@ -59,7 +59,7 @@ # NOTE: gerrit forks in wild ways that don't work with upstart - name: Setup a Sys-V init script - template: src=gerrit.sysv dest=/etc/init.d/gerrit mode=755 + template: src=gerrit.sysv dest=/etc/init.d/gerrit mode=0755 register: sysv - name: Run update-rc.d when Sys-V script is created diff --git a/roles/bugzilla/tasks/main.yml b/roles/bugzilla/tasks/main.yml index cb6ff0c4..eed703c6 100644 --- a/roles/bugzilla/tasks/main.yml +++ b/roles/bugzilla/tasks/main.yml @@ -67,7 +67,7 @@ - name: Setup data directory for next step file: path={{install_base}}/{{hostname}}/data - state=directory owner=root group=www-data mode=770 + state=directory owner=root group=www-data mode=0770 - name: Copy configuration template: src=templates/{{hostname}}-params.json diff --git a/roles/colo-router/tasks/main.yml b/roles/colo-router/tasks/main.yml index bc0ffa5c..4984b528 100644 --- a/roles/colo-router/tasks/main.yml +++ b/roles/colo-router/tasks/main.yml @@ -112,7 +112,7 @@ dest=/usr/local/bin/pdu_power owner=root group=root - mode=755 + mode=0755 tags: - pdu_power @@ -121,7 +121,7 @@ dest=/etc/pdu_power.conf owner=root group=root - mode=440 + mode=0440 tags: - pdu_power - colo_user @@ -131,6 +131,6 @@ dest=/etc/sudoers.d/pdu_power owner=root group=root - mode=440 + mode=0440 tags: - pdu_power diff --git a/roles/sslcert-self-signed/tasks/main.yml b/roles/sslcert-self-signed/tasks/main.yml index 1dd51d9f..9139c6a6 100644 --- a/roles/sslcert-self-signed/tasks/main.yml +++ b/roles/sslcert-self-signed/tasks/main.yml @@ -6,6 +6,6 @@ notify: - Restart Apache - name: Set permissions on certificate - file: path={{ssl_cert}} mode=600 + file: path={{ssl_cert}} mode=0600 - name: Set permissions on certificate key - file: path={{ssl_key}} mode=600 + file: path={{ssl_key}} mode=0600 -- cgit v1.2.3