diff options
| author | ydong10 <ydong10@6f19259b-4bc3-4df7-8a09-765794883524> | 2012-08-21 00:57:17 +0000 |
|---|---|---|
| committer | ydong10 <ydong10@6f19259b-4bc3-4df7-8a09-765794883524> | 2012-08-21 00:57:17 +0000 |
| commit | 34a2baa6be37a497b1b3f3f574cb8544c0603a3b (patch) | |
| tree | 85ff571739e6f645b89924de44e90479f79b06c8 /edk2/MdeModulePkg | |
| parent | 650d6cdeb16f5831e9c55e8fba11e16ac0342064 (diff) | |
Enhance the code to make the code logic more clear.
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk@13650 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'edk2/MdeModulePkg')
| -rw-r--r-- | edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 4 | ||||
| -rw-r--r-- | edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c | 3 |
2 files changed, 5 insertions, 2 deletions
diff --git a/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c index 8aced87c8..79829e664 100644 --- a/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c +++ b/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c @@ -815,7 +815,7 @@ GetToken ( String = HiiGetString (HiiHandle, Token, NULL);
if (String == NULL) {
- String = AllocateCopyPool (sizeof (mUnknownString), mUnknownString);
+ String = AllocateCopyPool (StrSize (mUnknownString), mUnknownString);
ASSERT (String != NULL);
}
return (CHAR16 *) String;
@@ -3269,7 +3269,7 @@ ExtractDefault ( //
// Initilize Questions' Value
//
- LoadFormSetConfig (NULL, LocalFormSet);
+ Status = LoadFormSetConfig (NULL, LocalFormSet);
if (EFI_ERROR (Status)) {
DestroyFormSet (LocalFormSet);
continue;
diff --git a/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c b/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c index f48afbf66..f3019a840 100644 --- a/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c +++ b/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c @@ -957,6 +957,9 @@ CreateDialog ( TempString[Index - 1] = CHAR_NULL;
StrCpy (StringBuffer, TempString);
}
+ //
+ // break skipped on purpose
+ //
default:
//
|